Skip to content

Add optional gateway screen actions#37

Merged
Pigbibi merged 1 commit into
mainfrom
codex/add-gateway-screen-actions
May 10, 2026
Merged

Add optional gateway screen actions#37
Pigbibi merged 1 commit into
mainfrom
codex/add-gateway-screen-actions

Conversation

@Pigbibi
Copy link
Copy Markdown
Collaborator

@Pigbibi Pigbibi commented May 10, 2026

Summary

  • let the manual screen capture workflow optionally click resend notification, challenge/response, or QR code before taking a screenshot
  • keep the workflow limited to the existing private IAP path and artifact capture

Tests

  • not run locally; workflow-only diagnostic helper

@Pigbibi Pigbibi merged commit 1ca43d3 into main May 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/add-gateway-screen-actions branch May 10, 2026 18:10
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2091a6c826

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +125 to +126
width=$(printf "%s\n" "$geometry" | awk -F= "/^WIDTH=/{print \\$2}")
height=$(printf "%s\n" "$geometry" | awk -F= "/^HEIGHT=/{print \\$2}")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix awk field escapes in geometry parsing

When screen_action is anything other than capture-only, these awk programs use \$2 inside double quotes, which causes Bash (with set -u) to expand shell positional parameter $2 instead of passing awk field $2; in bash -lc here $2 is unset, so the step exits before any click/screenshot action runs. This makes all new interactive actions fail consistently.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant